vistaslayer/LegacyRenouveau
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

game loop: Refactor the tooltips loop

Browse Source 
Moved the whole logic to a new file (TooltipManager.cpp), and rewrote most of the logic to profit from object oriented programming. The side-effect is that the changes are scattered across entities, tiles and items because moving everything to OOP requires to add the tooltip to every .cpp file for every tile/item/entities (or their class, on plants for example which all use the tooltip IDS_TOOLTIPS_PLANT)

The issue with the default tooltips loop written by 4J is that:

    Its running in the main Minecraft::tick loop and is more than a thousand lines long, polluting the function.
    Not using C++'s full potential with object oriented programming, 4J decided to use a big switch case (probably because it could run better on hardware without branch prediction like the WiiU or Xbox 360 ?)
    And seems to be better off in its own file than in the main Minecraft.cpp file
This commit is contained in:
Anaël
2026-10-04 20:54:24 +02:00
parent ffa6694864
commit d8d65bcd49
150 changed files with 6215 additions and 1527 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Minecraft.World/FlintAndSteelItem.cpp
+16 -4
View File
@@ -15,7 +15,7 @@ FlintAndSteelItem::FlintAndSteelItem(int id) : Item( id )
setMaxDamage(64);
}
bool FlintAndSteelItem::useOn(shared_ptr<ItemInstance> instance, shared_ptr<Player> player, Level *level, int x, int y, int z, int face, float clickX, float clickY, float clickZ, bool bTestUseOnOnly)
bool FlintAndSteelItem::useOn(shared_ptr<ItemInstance> instance, shared_ptr<Player> player, Level *level, int x, int y, int z, int face, float clickX, float clickY, float clickZ, bool bTestUseOnOnly)
{
// 4J-PB - Adding a test only version to allow tooltips to be displayed
if (face == 0) y--;
@@ -24,14 +24,14 @@ bool FlintAndSteelItem::useOn(shared_ptr<ItemInstance> instance, shared_ptr<Play
if (face == 3) z++;
if (face == 4) x--;
if (face == 5) x++;
if (!player->mayUseItemAt(x, y, z, face, instance)) return false;
int targetType = level->getTile(x, y, z);
if(!bTestUseOnOnly)
{
if (targetType == 0)
{
if (targetType == 0)
{
if( level->getTile(x, y-1, z) == Tile::obsidian_Id )
{
@@ -70,3 +70,15 @@ bool FlintAndSteelItem::useOn(shared_ptr<ItemInstance> instance, shared_ptr<Play
return true;
}
int FlintAndSteelItem::getUseTooltipId(std::shared_ptr<ItemInstance> itemInstance, std::shared_ptr<Player> player, Level* level, int x, int y, int z, bool bUseItem) const
{
if (bUseItem && level != nullptr)
{
int targetType = level->getTile(x, y, z);
if (targetType != 0)
return IDS_TOOLTIPS_IGNITE;
}
return 0;
}